From: Karthik Nayak <karthik.188@gmail.com>
Date: Mon, 01 Jun 2015 19:28:47 GMT
Subject: Re: [WIP/PATCH v4 6/8] for-each-ref: rename some functions and make them public
Message-ID: <AD4CBEF2-90E7-4C75-89BF-A7C3E9F367B2@gmail.com>
In-Reply-To: <vpqoal0hr0e.fsf@anie.imag.fr>



On June 1, 2015 12:08:57 PM GMT+05:30, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
>Christian Couder <christian.couder@gmail.com> writes:
>
>> sort_refs() -> ref_array_sort()
>> struct ref_sort -> struct ref_sort_criteria
>> default_sort() -> ref_default_sort_criteria()
>> opt_parse_sort() -> opt_parse_ref_sort_criteria()
>
>BTW, having such summary in the log message would help review: we could
>think and discuss the naming by looking just at the summary, and then
>check that you did it correctly (easy).

Yes agreed, will do that.