From: Väinö Järvelä Date: Sat, 04 Aug 2007 11:36:47 GMT Subject: Re: [PATCH] git-gui: Added support for OS X right click Message-ID: In-Reply-To: <20070804065516.GS20052@spearce.org> On Aug 4, 2007, at 09:55, Shawn O. Pearce wrote: > I had a devil of a time applying your patch though. git-am > choked because the patch was whitespace damaged, and then after > hand-correction and resuming it horribly munged your name's encoding > in the commit. I think there's a bug in there in git-am; I'll > have to try to track it down. I managed to get the patch applied > correctly by editing the mbox file directly, so that git-am did > not need to stop and ask me to resolve the patch. You are right in that Mail.app seems to eat up the whitespaces in the patch. I emailed the patch first to myself, and everything seemed fine, should have tested it with git-am rather than eyeballing it, sorry. About the name-munging, that didn't happen for me, after i fixed the spacing with Vim, the name shows up correctly in Git log. It seems that the email is ISO-8859-1 encoded, I'll enforce UTF-8 encoding next time if it helps, and I'll see if I can send an inlined patch which works. -- Väinö