From: Lars Schneider <larsxschneider@gmail.com>
Date: Fri, 09 Mar 2018 19:04:34 GMT
Subject: Re: [PATCH v11 07/10] convert: check for detectable errors in UTF encodings
Message-ID: <AB377212-0551-4DFF-A953-734DC847934B@gmail.com>
In-Reply-To: <xmqqy3j15b2h.fsf@gitster-ct.c.googlers.com>


> On 09 Mar 2018, at 20:00, Junio C Hamano <gitster@pobox.com> wrote:
> 
> lars.schneider@autodesk.com writes:
> 
>> +			const char *advise_msg = _(
>> +				"The file '%s' contains a byte order "
>> +				"mark (BOM). Please use %.6s as "
>> +				"working-tree-encoding.");
> 
> I know that this will go away in a later step, but why ".6"?

I deleted the original comment in the rebase, sorry:

    /*
     * This advice is shown for UTF-??BE and UTF-??LE
     * encodings. We truncate the encoding name to 6
     * chars with %.6s to cut off the last two "byte
     * order" characters.
     */

- Lars