From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Mon, 30 Aug 2010 01:35:51 GMT
Subject: Re: [PATCH 10/13] transport-helper: implement marks location as capability
Message-ID: <AANLkTinyuCoC7P2kSS7epgfO3xjJ8mTEQ+P8qtsEmAct@mail.gmail.com>
In-Reply-To: <20100830013156.GD2305@burratino>

Heya,

On Sun, Aug 29, 2010 at 20:31, Jonathan Nieder <jrnieder@gmail.com> wrote:
> This seems fragile to me: shouldn't the remote helper check somehow
> that the line it read was actually a gitdir line?

You're probably right, the simplest way would be to check if repo.gitdir is set.

> No other complaint on my part.  Requiring a flush seems entirely
> appropriate to me, and if someone comes up with something nicer than
> the "capabilities" sequence for requesting information, it would not
> be the end of the world to have two ways to discover the .git dir.

Agreed.

-- 
Cheers,

Sverre Rabbelier