From: Erik Faye-Lund Date: Tue, 28 Sep 2010 21:47:38 GMT Subject: Re: [PATCH/RFC 0/2] use libcharset.h with gettext if available Message-ID: In-Reply-To: <1285698577-28395-1-git-send-email-avarab@gmail.com> On Tue, Sep 28, 2010 at 8:29 PM, Ævar Arnfjörð Bjarmason wrote: > Yeah, I'm hoping it'll get into next soon so we can get more > reports/fixes like these. Anyway, I amended your patches a bit, here > are the changes: > >  * Split up the s/char*/const char*/ change into its own patch, or is >   there a reason for why this needs to be there along with the >   libcharset.h change? > The reason was that my version of locale_charset() returns a const char *, so I got a warning if I didn't. nl_langinfo() returns a char *, so I don't think that constness-fix patch makes sense in itself. But what might make more sense would be to squash it into the original commit for that line. >  * Added docs about the define to the Makefile > Nice! >  * Added defaults for NO_LIBCHARSET to the default, I only changed the >   defaults for the MINGW entry, maybe it should be changed on Cygwin >   and Windows too? And probably on OpenBSD and NetBSD too. > I don't think NO_LIBCHARSET should be the default. libcharset is reported to be a bit better than nl_langinfo at normalizing the encoding, and GNU gettext depends on libcharset (through libiconv, which libcharset is distributed with). So in the case of a GNU gettext, libcharset should really be present. > Erik Faye-Lund (2): >  gettext: use const char* instead of char* >  gettext: use libcharset when available > >  Makefile     |   17 +++++++++++++++++ >  configure.ac |    6 ++++++ >  gettext.c    |   10 +++++++++- >  3 files changed, 32 insertions(+), 1 deletions(-) > > -- > 1.7.3.159.g610493 > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html >