From: Thiago Farina <tfransosi@gmail.com>
Date: Fri, 26 Nov 2010 19:20:11 GMT
Subject: Re: [PATCH 1/5] cache.h: remove surrounding brackes and realign CE_* constants
Message-ID: <AANLkTinwP=tDYyeyjX8uUChtvOeVmT4QfZjxT0A67hop@mail.gmail.com>
In-Reply-To: <1290795467-7570-2-git-send-email-pclouds@gmail.com>

2010/11/26 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  cache.h |   25 ++++++++++++-------------
>  1 files changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/cache.h b/cache.h
> index 33decd9..4819cf5 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -170,26 +170,25 @@ struct cache_entry {
>  *
>  * In-memory only flags
>  */
> -#define CE_UPDATE    (0x10000)
> -#define CE_REMOVE    (0x20000)
> -#define CE_UPTODATE  (0x40000)
> -#define CE_ADDED     (0x80000)
> +#define CE_UPDATE              0x10000
> +#define CE_REMOVE              0x20000
> +#define CE_UPTODATE            0x40000
> +#define CE_ADDED               0x80000
>
Thanks for fixing this. Maybe these hex can be rewriting as 1 << 0, 1
<< 1 and so on?