From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Tue, 23 Nov 2010 17:51:42 GMT
Subject: Re: [RFC PATCH 6/6] win32: use our own dirent.h
Message-ID: <AANLkTinvtdwP_C1PcFkOXfFEHfOAj3dPAfa1xyUrttEu@mail.gmail.com>
In-Reply-To: <20101123174519.GE12113@burratino>

On Tue, Nov 23, 2010 at 6:45 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Erik Faye-Lund wrote:
>
>> This provides a generic Win32-implementation of opendir, readdir
>> and closedir which works on both MinGW and MSVC and does not reset
>> errno, and as a result git clone is working again on Windows.
>
> Nice!  Thanks.
>
>>  Makefile                        |    7 ++-
>>  compat/mingw.c                  |   60 ------------------
>>  compat/mingw.h                  |   29 ---------
>>  compat/msvc.c                   |   49 ---------------
>>  compat/vcbuild/include/dirent.h |  128 ---------------------------------------
>>  compat/win32/dirent.c           |  105 ++++++++++++++++++++++++++++++++
>>  compat/win32/dirent.h           |   24 +++++++
>>  7 files changed, 134 insertions(+), 268 deletions(-)
>>  delete mode 100644 compat/vcbuild/include/dirent.h
>>  create mode 100644 compat/win32/dirent.c
>>  create mode 100644 compat/win32/dirent.h
>
> Does this diff get smaller with -M -C -C -C?
>

Nope. I guess the reason is that I've adjusted the code a bit while
moving it, because I didn't need to cast back and forth between HANDLE
anymore.