From: Nguyen Thai Ngoc Duy Date: Thu, 10 Mar 2011 06:52:41 GMT Subject: Re: [PATCH 3/5] revision.c: get rid of struct rev_info.prune_data Message-ID: In-Reply-To: <7vhbbb7ays.fsf@alter.siamese.dyndns.org> 2011/3/10 Junio C Hamano : >> In some places, this pathspec is used, in other places another >> ... but i'm >> not sure why diffopt can't be used in place of pruning. > > A command in the "log" family uses revision traversal and uses one > pathspec (pruning.pathspec) to cull side branches and skip irrelevant > commits, and another pathspec (diffopt.pathspec) to specify how the found > commit is shown.  Off the top of my head, currently the only case the > pathspec of these diff options differ is when --full-diff is used, but > they are independent concepts. OK then I did it wrong. I should have removed prune_data in favor of pruning.pathspec, leaving diffopt.pathspec intact. -- Duy