From: Nguyen Thai Ngoc Duy Date: Mon, 04 Oct 2010 09:25:00 GMT Subject: Re: [PATCH 4/7] setup: make sure git dir path is in a permanent buffer Message-ID: In-Reply-To: <20101002083652.GE29638@burratino> On Sat, Oct 2, 2010 at 3:36 PM, Jonathan Nieder wrote: > It is not obvious whether any existing code in git will trigger the > problem, but in any case, it is worth a few dozen bytes to copy the > return value from make_absolute_path() for some added peace of mind. It looks like make_absolute_path() is only used when git_dir has not been set in stone yet. Anyway, yes yes yes! I don't want to pull my hair when I find out this bug hits me. -- Duy