From: Nguyen Thai Ngoc Duy Date: Sun, 05 Sep 2010 02:00:24 GMT Subject: Re: [RFC PATCH 05/15] read_tree_recursive: Avoid missing blobs and trees in a sparse repository Message-ID: In-Reply-To: <1283645647-1891-6-git-send-email-newren@gmail.com> On Sun, Sep 5, 2010 at 10:13 AM, Elijah Newren wrote: > @@ -119,6 +119,11 @@ int read_tree_recursive(struct tree *tree, >                default: >                        return -1; >                } > + > +               if (git_sparse_pathspecs && > +                   sha1_object_info(entry.sha1, NULL) <= 0) > +                       continue; > + I suppose this is temporary and the final solution would have stricter checks (i.e. only ignore if those entries are outside sparse zone)? This opens a door for broken repo. -- Duy