From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Mon, 11 Oct 2010 22:28:40 GMT
Subject: Re: [PATCH v4 02/15] mingw: implement syslog
Message-ID: <AANLkTinkpTavtw3Rmubfht56tzGnHckHXRc0L-C83daE@mail.gmail.com>
In-Reply-To: <20101011221146.GB6277@burratino>

On Tue, Oct 12, 2010 at 12:11 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Erik Faye-Lund wrote:
>
>> Strings containing "%1" gets corrupted by ReportEvent, so expand
>> "%1" to "% 1" before reporting.
>
> What is the symptom?  Can clients trigger this, and is it worth
> preventing them from doing so?
>

The string gets inlined into itself (with a limit of 100 expansions)
leading to string like "foo %1 bar" becoming "foo foo foo ... foo %1
bar bar bar ... bar". With our expansion, it becomes "foo % 1 bar"
instead.