From: Pavan Kumar Sunkara Date: Mon, 24 May 2010 15:14:13 GMT Subject: Re: [PATCHv3 GSoC] git-instaweb: Configure it to work with new gitweb structure Message-ID: In-Reply-To: <201005241155.30653.chriscool@tuxfamily.org> On Mon, May 24, 2010 at 3:25 PM, Christian Couder wrote: > Hi Pavan, > > On Sunday 23 May 2010 09:32:48 Pavan Kumar Sunkara wrote: >> >> This patch is based on 'jn/gitweb-install' in the next branch by Jakub >>  Nareski and my previous 2 patches: >> * gitweb: Move static files into seperate subdirectory >>  http://article.gmane.org/gmane.comp.version-control.git/147321 >> * gitweb: Set default destination directory for installing gitweb in >>  Makefile http://article.gmane.org/gmane.comp.version-control.git/147160 > > I tried to apply your 2 patches on top of next I got some errors with the > "Move static files into seperate subdirectory" patch. It is a small error in Makefile only with this patch. The others are ok. I teseted it with alt-git.git repository's next branch. So, I will be sending only that patch once again. > Could you resend the 3 patches in a patch series after making sure that they > apply on top of next? > > And I think that it would be better if the web server logs would be in a > directory with the web server name. For example > "$fqgitdir/gitweb/$httpd/access.log" instead of "$fqgitdir/gitweb/access.log". > But it would be nice if you make these changes (as well as the apache2 > confguration changes) in another patch. > Yeah. Sure. - Pavan