From: Emil Sit <sit@emilsit.net>
Date: Mon, 13 Sep 2010 16:17:26 GMT
Subject: Re: [PATCH 2/2] log --author: take union of multiple "author" requests
Message-ID: <AANLkTinaj4AsPE9j-gS2-0Cn8jx7a1uYYGtmq5oC=YVB@mail.gmail.com>
In-Reply-To: <7vmxrmawg0.fsf_-_@alter.siamese.dyndns.org>

On Mon, Sep 13, 2010 at 4:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
>    log --author=me --author=her \
>        --committer=him --committer=you \
>        --grep=this --grep=that
>
> into
>
>    (ALL-MATCH
>      (OR (HEADER-AUTHOR me) (HEADER-AUTHOR her))
>      (OR (HEADER-COMMITTER him) (HEADER-COMMITTER you))
>      (OR (PATTERN this) (PATTERN that)))

Both patches look good to me.  Tested fine with my use cases. Thanks
for doing this.

I'm a little confused about the implementation with regards to
--all-match; does there still need to be an all-match flag?  Seems
like it has now been deprecated (to being, essentially, the default).
In any case, there should also probably something going along with
this patch series to update Documentation/rev-list-options.txt.

Thanks again.

-- 
Emil Sit / http://www.emilsit.net/