From: Piotr Krukowiecki Date: Mon, 21 Mar 2011 18:46:22 GMT Subject: Re: [PATCH 1/2] diff/status: refactor opportunistic index update Message-ID: In-Reply-To: <7vtyewqtmk.fsf@alter.siamese.dyndns.org> On Mon, Mar 21, 2011 at 6:16 PM, Junio C Hamano wrote: > +void update_index_if_able(struct index_state *istate, struct lock_file *lockfile) > +{ > +       if (istate->cache_changed) && > +           !write_index(istate, lockfile->fd)) Mismatched parenthesis? Should be sth like +       if (istate->cache_changed && +           !write_index(istate, lockfile->fd)) -- Piotr Krukowiecki