From: Nguyen Thai Ngoc Duy Date: Wed, 09 Feb 2011 11:21:33 GMT Subject: Re: [PATCH 5/7] help: reuse struct column_layout Message-ID: In-Reply-To: <20110209073953.GB2135@elie> 2011/2/9 Jonathan Nieder : > Nguyễn Thái Ngọc Duy wrote: > > [...] >> +++ b/help.c >> @@ -72,29 +73,17 @@ void exclude_cmds(struct cmdnames *cmds, struct cmdnames *excludes) > [...] >> +     struct column_layout c; >> +     int i; >> + >> +     memset(&c, 0, sizeof(c)); > > Might be nice to have a COLUMN_LAYOUT_INIT, I suppose. > > Looks sane.  What output changes would be noticeable, if any? Two spaces between column instead of one. Will fix. -- Duy