From: Nguyen Thai Ngoc Duy Date: Thu, 19 Aug 2010 22:11:45 GMT Subject: Re: [PATCH 3/3] {fetch,upload}-pack: allow --depth=0 to deepen into full repo again Message-ID: In-Reply-To: On Fri, Aug 20, 2010 at 7:22 AM, Jakub Narebski wrote: > Nguyễn Thái Ngọc Duy   writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >>  The funny thing is, even with --depth=0, I still have two commit grafts >>  in $GIT_DIR/shallow, which are grafts of tags. I think there is a bug >> somewhere.. >> >>  builtin/fetch-pack.c |    2 +- >>  shallow.c            |    2 +- >>  upload-pack.c        |    8 ++++---- >>  3 files changed, 6 insertions(+), 6 deletions(-) >> > > Fist, it lacks documentation update that --depth=0 means infinite > depth (making repository not-shallow). Yeah. I would do documentation and tests later once I figured out why --depth=0 did not give me full repo. It turns out I need --tags to (refetch?) tags and have full repo. > Second, it would be nice (though probably not easy with parseopt, as > it would require hacks/extensions) to be able to use --depth=inf > (like wget supports '-l inf') to mean infinite depth... Hmm.. make --depth a string parameter and fetch-pack should parse the parameter itself, like git-clone. Good idea. -- Duy