From: Pat Notz Date: Fri, 17 Sep 2010 17:23:13 GMT Subject: Re: [PATCH 1/2] dir.c: fix uninitialized memory warning Message-ID: In-Reply-To: For anyone who care, this warning was actually emitted by the version of GCC that ships with MacOS 10.5: i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5493). GCC 4.4.4 does *not* git this warning. Sorry for the confusion, my IDE was using a different $PATH than my shell. On Thu, Sep 16, 2010 at 7:13 PM, Pat Notz wrote: > On Thu, Sep 16, 2010 at 7:04 PM, Nguyen Thai Ngoc Duy wrote: >> On Fri, Sep 17, 2010 at 10:32 AM, Pat Notz wrote: >>>> I don't see any case that "size" can be used uninitialized. Maybe the >>>> compiler was confused by >>>> >>>> if (!check_index || >>>>    (buf = read_skip_worktree_file_from_index(fname, &size)) == NULL) >>>>        return -1; >>>> >>> >>> No, line 245: if(size==0) >> >> The only chance for that line to be executed is read_skip_*() is >> executed and returns non-NULL buf. read_skip*() returns a non-NULL >> buffer at the end of function and does set size right before >> returning. >> >> To me it looks like a false alarm. But again, no objection to the patch. > > I agree that it's a false alarm which is why I wasn't too interested > in looking into it very deeply.  Just looking to keep the code warning > free is all. > >> -- >> Duy >> >