From: Ralf Thielow Date: Wed, 01 Dec 2010 20:44:42 GMT Subject: Re: [PATCH] commit: Remove backward goto in read_craft_line() Message-ID: In-Reply-To: <20101201203132.GB27845@burratino> > If "--show-c-function" output is the problem, perhaps we should know a bit > better about what C function header looks like? In fact the "--show-c-function" output is the problem. But I think that a change can't be rejected because of another issue. The style of placing "goto"-statements, which leave a function to the end of that is used in many other projects. And I think it's very usefull. 2010/12/1 Jonathan Nieder : > Junio C Hamano wrote: >> Jonathan Nieder writes: > >>> A space before the "bad_graft_data:" label would improve future >>> diff --show-c-function output. >> >> Hmm, I actually do not think we encourage that (nor we should). >> >>     $ git grep -e '^ [a-z0-9]*:' -- '*.c' | wc -l >>     23 >>     $ git grep -e '^[a-z0-9]*:' -- '*.c' | wc -l >>     42 >> >> If "--show-c-function" output is the problem, perhaps we should know a bit >> better about what C function header looks like? > > Thanks for checking.  Yes, I think so. > >        $ git grep --show-function strbuf_release -- http.c >        http.c=static int http_request(const char *url, void *result, int target, int options) >        http.c: strbuf_release(&buf); >        http.c=cleanup: >        http.c: strbuf_release(&tmpfile); >        http.c=int http_fetch_ref(const char *base, struct ref *ref) >        http.c: strbuf_release(&buffer); > > The following gives me some joy. > > Signed-off-by: Jonathan Nieder > --- > diff --git a/.gitattributes b/.gitattributes > index 5e98806..5888a53 100644 > --- a/.gitattributes > +++ b/.gitattributes > @@ -1,3 +1,4 @@ >  * whitespace=!indent,trail,space >  *.[ch] whitespace=indent,trail,space > +*.[ch] diff=cpp >  *.sh whitespace=indent,trail,space >