From: Piotr Krukowiecki <piotr.krukowiecki.news@gmail.com>
Date: Sun, 13 Feb 2011 16:26:51 GMT
Subject: Re: [PATCH] Don't optimize code in debug build
Message-ID: <AANLkTinECgZwFZ0157O-qvYUW1GpJgbsHDekR1WM6gPm@mail.gmail.com>
In-Reply-To: <AANLkTim6OHU8N7t5RQnt6S7x7ez48RSwp=b82McAC4Oq@mail.gmail.com>

(forgot about the list when replying)

> On Sun, Feb 13, 2011 at 10:36 AM, Johannes Sixt <j6t@kdbg.org> wrote:
>> On Sonntag, 13. Februar 2011, Piotr Krukowiecki wrote:
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -262,7 +262,10 @@ endif
>>>
>>>  # CFLAGS and LDFLAGS are for the users to override from the command line.
>>>
>>> -CFLAGS = -g -O2 -Wall
>>> +CFLAGS = -g -Wall
>>> +ifndef DEBUG
>>> +CFLAGS += -O2
>>> +endif
>>>  LDFLAGS =
>>>  ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS)
>>>  ALL_LDFLAGS = $(LDFLAGS)
>>
>> Instead of this, you can just write
>>
>>  CFLAGS = -g -Wall
>>
>> in your config.mak. Is anything wrong with that?

Several things: I need to know I should remove -O2, I need to keep in
sync with other default options, current default is less useful, it
requires me to do extra steps.
DEBUG is kind of standard - Makefile already uses it in Windows
specific part. I suppose we want to keep consistent.

-- 
Piotrek