From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Wed, 24 Nov 2010 10:16:27 GMT
Subject: Re: [StGIT PATCH] contrib/vim: Add vim syntax highlighting for StGit commit messages
Message-ID: <AANLkTinBT9Hd2EA9Wqu4FjRDmc=DNCRsrqopb_n3KOkm@mail.gmail.com>
In-Reply-To: <AANLkTinS7LrG9ROy+3BLchWEi3=-7E0FFy+9_eJiaswW@mail.gmail.com>

On 24 November 2010 00:38, Chris Packham <judge.packham@gmail.com> wrote:
> On Wed, Nov 24, 2010 at 4:46 AM, Zane Bitter
> <zane.bitter@alliedtelesis.co.nz> wrote:
>>
>
> I'm not sure about how Catalin runs stgit, but in for git having a
> Signed-off-by: line is mandatory and usually indicates that the patch
> considered ready for inclusion and acts as the "developers certificate
> of authenticity" (i.e. it is the developers own work or the developer
> has based it on other compatibly licensed code).
>
> A commit message would also be nice but in this case I think it just
> does what it says on the tin.

That would be nice but I'm not usually rejecting patches on this basis.

> For the reviewers I can add that I've been using Zane's patch for a
> while now and it works well for me (although I'm not exactly a vim
> guru).

I can add a Tested-by then :)

-- 
Catalin