From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Sat, 24 Jul 2010 00:50:09 GMT
Subject: Re: [PATCH 1/2] worktree setup: return to original cwd if prefix is set NULL
Message-ID: <AANLkTin6xGRz7wFyWtYg4ysPPytEW-uQn8ij1YbjJ_m9@mail.gmail.com>
In-Reply-To: <AANLkTimkwfetLWynKCGVxMT0ZzHOZQp_iknrohoV8A79@mail.gmail.com>

2010/7/24 Ævar Arnfjörð Bjarmason <avarab@gmail.com>:
> 2010/7/23 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:
>
>> +test_expect_success 'cwd is unchanged when prefix is NULL (from within a repo)' '
>> +       (
>> +               cd repo.git/objects &&
>> +               echo 1 > one &&
>> +               cp one expected &&
>> +               echo 2 >> expected &&
>> +               git apply patch &&
>> +               test_cmp expected one &&
>> +               rm one expected patch
>> +       )
>> +'
>
> Is the rm at the end needed here?
>
> This is a minor nit, but it's generally helpful for debugging tests
> that things aren't removed if the --debug option is specified.
>

I don't want to pollute the repo early. If the test fails, rm would not be run.
-- 
Duy