From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Wed, 18 Aug 2010 19:14:50 GMT
Subject: Re: [FreeBSD? BUG]: t1304-default-acl.sh fails on FreeBSD 8.1-STABLE
Message-ID: <AANLkTin5wc4+N5yhs=RipxVnY0aiX-5ptQKDL-z__Jyt@mail.gmail.com>
In-Reply-To: <AANLkTikTu2vSCMPqtFvD964XsURayf2MNGSVW1nAaY1d@mail.gmail.com>

On Tue, Aug 17, 2010 at 03:17, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> t/t1304-default-acl.sh fails on FreeBSD, seemingly because setfacl on
> FreeBSD doesn't have a meaningful return code:
>
>    $ setfacl -m u:root:rwx . ; echo $?
>    setfacl: .: acl_get_file() failed: Operation not supported
>    0
>
> But on Linux:
>
>    $ setfacl -m u:root:rwx . ; echo $?
>    setfacl: .: Operation not supported
>    1
>
> The Solaris setfacl also behaves.
>
> The FreeBSD manpage says this:
>
>    EXIT STATUS
>         The setfacl utility exits 0 on success, and >0 if an error occurs.
>
> Anyone here know more about FreeBSD to shed light on this?

I sent this upstream with a patch:
http://www.freebsd.org/cgi/query-pr.cgi?pr=149780