From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 15 Jul 2010 15:32:57 GMT
Subject: Re: [PATCH] grep: Don't pass a TODO test if REG_STARTEND is supported
Message-ID: <AANLkTin5a39MQurIdXYu-SZVLhNTefbyZmJALT5SrdQF@mail.gmail.com>
In-Reply-To: <4C364A0B.2020909@lsrfire.ath.cx>

On Thu, Jul 8, 2010 at 21:58, René Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:

> In this particular case the tested functionality is not provided accross
> all platforms supported by git.  It would be better to fix the actual
> issue, namely that the fallback regex lib we provide doesn't support
> REG_STARTEND.

We're currently providing the GNU regex library, it seems Mac OS X and
FreeBSD ship with a regex library that has REG_STARTEND (according to
`git log --reverse compat/regex` the current library was added because
of incompatibilities on OSX, but those were since fixed in
310e0216c8).

If the FreeBSD and Mac OS X implementations are good enough we could
just swap the GNU one for the FreeBSD one
(http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/regex/). Is there
any reason not to do this, or would a different regex library be a
better fit?