From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 31 Jul 2010 00:44:00 GMT
Subject: Re: [PATCH 2/2] checkout: add a test for creating a new branch with regexp as a starting point
Message-ID: <AANLkTin11hHryAbJiOkiBH5TfpPbKREJK-ekWkd4fDhw@mail.gmail.com>
In-Reply-To: <20100731001919.GB24129@wo.int.altlinux.org>

On Sat, Jul 31, 2010 at 00:19, Dmitry V. Levin <ldv@altlinux.org> wrote:
> Reported-by: Ivan Zakharyaschev <imz@altlinux.org>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
>  t/t2018-checkout-branch.sh |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/t/t2018-checkout-branch.sh b/t/t2018-checkout-branch.sh
> index 1caffea..4d26b2a 100755
> --- a/t/t2018-checkout-branch.sh
> +++ b/t/t2018-checkout-branch.sh
> @@ -118,7 +118,20 @@ test_expect_success 'checkout -b to an existing branch fails' '
>        test_must_fail do_checkout branch2 $HEAD2
>  '
>
> +test_expect_failure 'checkout -b new_branch :/regexp' '
> +       # clean up from previous test
> +       git reset --hard &&
> +
> +       do_checkout old_regexp_branch branch1 &&
> +       test_commit first '' '' '' &&
> +       test_commit second '' '' '' &&

Should note in the commit message or a comment that this test needs to
not create a tag, in case someone wonders down the line what the '' ''
'' ASCII art is all about :)

Looks good otherwise, thanks for patching test_commit.