From: Ramana Kumar <ramana.kumar@gmail.com>
Date: Tue, 14 Sep 2010 09:08:39 GMT
Subject: Re: [PATCH] Make commit help text more accurate for --verbose
Message-ID: <AANLkTin0W3HOwSQVFR_cm9oJzYib2yULkUc19Pg4yJD6@mail.gmail.com>
In-Reply-To: <AANLkTikLTykbgUjCK4H0cbF0QXZHOPYbLdptEKe4-rD5@mail.gmail.com>

On Mon, Sep 6, 2010 at 2:30 AM, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> On Sun, Sep 5, 2010 at 15:06, Thiago Farina <tfransosi@gmail.com> wrote:
>> Hi Ramana,
>>
>> Some *style* comments below.
>> On Sun, Sep 5, 2010 at 6:53 AM, Ramana Kumar <ramana.kumar@gmail.com> wrote:
>>>                fprintf(fp,
>>>                        "\n"
>>>                        "# Please enter the commit message for your changes.");
>>> -               if (cleanup_mode == CLEANUP_ALL)
>>> +               if (cleanup_mode == CLEANUP_ALL && !verbose)
>>>                        fprintf(fp,
>>>                                " Lines starting\n"
>>>                                "# with '#' will be ignored, and an empty"
>>>                                " message aborts the commit.\n");
>> The Documentation/CodingStyle says to avoid using braces unncessary.
>> But since this is not a single line statement, like:
>> if (foo)
>>  foo = x;
>>
>> Could you wrapp this into { } ?
>
> The braces are still unncessary if the function call is spread across
> a few lines. I haven't seen anything in the source that indicates that
> we prefer braces when a braceless if/else has an associated statement
> that exceeds 1 line.

Any other suggestions to improve this patch?