From: Ævar Arnfjörð Bjarmason Date: Sun, 29 Aug 2010 19:39:34 GMT Subject: Re: [PATCH 1/6] Add string comparison functions that respect the ignore_case variable. Message-ID: In-Reply-To: <201008182032.40375.j6t@kdbg.org> On Wed, Aug 18, 2010 at 18:32, Johannes Sixt wrote: > On Mittwoch, 18. August 2010, Ævar Arnfjörð Bjarmason wrote: >> According to some further research at least FreeBSD and NetBSD have >> copied this GNU extension. You may find their versions easier to >> integrate. > > We already have a GNU fnmatch in compat/fnmatch. Do you have any plan to deal with this? I currently have this monkeypatch to build on Solaris: diff --git a/Makefile b/Makefile index 62d526a..079fae5 100644 --- a/Makefile +++ b/Makefile @@ -863,2 +863,4 @@ endif ifeq ($(uname_S),SunOS) + COMPAT_OBJS = compat/fnmatch/fnmatch.o + COMPAT_CFLAGS = -Icompat -Icompat/fnmatch NEEDS_SOCKET = YesPlease One way to deal with it would be a new NONGNU_FNMATCH=UnfortunatelyYes flag, or the fnmatch_icase() suggestion above which we could bundle and always use. But having next build on systems without GNU extensions would be preferrable.