From: Thomas Adam <thomas@xteddy.org>
Date: Wed, 06 Oct 2010 22:56:42 GMT
Subject: Re: [RFC/PATCHv5 18/17] gitweb/lib - Add clear() and size() methods to caching interface
Message-ID: <AANLkTimpXJT-R5vgdS4SvpuvhVOL-HCJxELMbfRcuqx5@mail.gmail.com>
In-Reply-To: <1286402526-13143-19-git-send-email-jnareb@gmail.com>

On 6 October 2010 23:02, Jakub Narebski <jnareb@gmail.com> wrote:
> Add ->size() method, which following Cache::Cache interface returns
> estimated total size of all entries in whole cache (in the namsepace
> assiciated with give cache instance).  Note that ->get_size($key)
> returns size of a single entry!
>
> Add ->clear() method, which removes all entries from the namespace
> associated with given cache instance.  For safety it requires
> namespace to be set to true value, which means that it cannot be
> empty; therefore default namespace is changed to 'gitweb'.
>
> The ->clear() method should be fairly safe, because it first renames
> directory (which should be atomic), and only then removes it
> (following code from CGI::Driver::File).
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> The only difference from previous version is that a comment about some
> method was moved to earlier commit that introduced it, where it
> belongs.
>
> This patch (implementing "backend") together with next patch
> (implementing "interface") are meant to provide nice web interface to
> safely cleaning (pruning) cache, as described in comments and
> documentation (how to do this manually).
>
>  gitweb/lib/GitwebCache/SimpleFileCache.pm |   48 ++++++++++++++++++++++++++--
>  t/t9503/test_cache_interface.pl           |    1 -
>  2 files changed, 44 insertions(+), 5 deletions(-)
>
> diff --git a/gitweb/lib/GitwebCache/SimpleFileCache.pm b/gitweb/lib/GitwebCache/SimpleFileCache.pm
> index 2a3d9cf..8f172cb 100644
> --- a/gitweb/lib/GitwebCache/SimpleFileCache.pm
> +++ b/gitweb/lib/GitwebCache/SimpleFileCache.pm
> @@ -20,8 +20,9 @@ package GitwebCache::SimpleFileCache;
>  use strict;
>  use warnings;
>
> -use File::Path qw(mkpath);
> -use File::Temp qw(tempfile);
> +use File::Path qw(mkpath rmtree);
> +use File::Temp qw(tempfile mktemp);
> +use File::Find qw(find);
>  use Digest::MD5 qw(md5_hex);
>
>  # by default, the cache nests all entries on the filesystem single
> @@ -37,7 +38,7 @@ our $DEFAULT_CACHE_ROOT = "cache";
>  # by default we don't use cache namespace (empty namespace);
>  # empty namespace does not allow for simple implementation of clear() method.
>  #
> -our $DEFAULT_NAMESPACE = '';
> +our $DEFAULT_NAMESPACE = "gitweb";
>
>  # ......................................................................
>  # constructor
> @@ -334,7 +335,7 @@ sub get_size {
>  }
>
>  # ......................................................................
> -# interface methods
> +# interface methods dealing with single item
>
>  # Removing and expiring
>
> @@ -427,6 +428,45 @@ sub compute {
>        return $data;
>  }
>
> +# ......................................................................
> +# interface methods dealing with whole namespace
> +
> +# $cache->clear();
> +#
> +# Remove all entries from the namespace.
> +# Namespace must be defined and not empty.
> +sub clear {
> +       my $self = shift;
> +
> +       return unless $self->get_namespace();
> +
> +       my $namespace_dir = $self->path_to_namespace();
> +       return if !-d $namespace_dir;
> +
> +       my $renamed_dir = mktemp($namespace_dir . '.XXXX');
> +       rename($namespace_dir, $renamed_dir);
> +       rmtree($renamed_dir);
> +       die "Couldn't remove '$renamed_dir' directory"
> +               if -d $renamed_dir;
> +}
> +
> +# $size = $cache->size();
> +#
> +# Size of whole names (or whole cache if namespace empty)
> +sub size {
> +       my $self = shift;
> +
> +       my $namespace_dir = $self->path_to_namespace();
> +       return if !-d $namespace_dir;
> +
> +       my $total_size = 0;
> +       my $add_size = sub { $total_size += -s $_ };
> +
> +       File::Find::find({ wanted => $add_size, no_chdir => 1 }, $namespace_dir);
> +
> +       return $total_size;
> +}
> +
>  1;

This looks good to me.

Acked-by:  Thomas Adam <thomas@xteddy.org>

-- Thomas Adam