From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 19 Jun 2010 11:58:59 GMT
Subject: Re: [PATCH] notes: Initialize variable to appease Sun Studio
Message-ID: <AANLkTimmnlHmt6LTHFKUtJZ7taSF10p4Pkna4CCb1G_J@mail.gmail.com>
In-Reply-To: <7vvd9fwrmc.fsf@alter.siamese.dyndns.org>

On Sat, Jun 19, 2010 at 04:52, Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Sun Studio 12 Update 1 thinks that *t could be uninitialized,
>> ostensibly because it doesn't take rewrite_cmd into account in its
>> static analysis.
>
> Hmm, I am wondering if I should apply this or just tell you to fix your
> compiler ;-)

I just noticed it when testing on Solaris, I don't use it regularly.

IIRC pretty much exactly the same changes were proposed for
compatibility with HP/UX a while back, and looking through the source
it seems a lot of things initialize struct pointers to NULL. Although
I haven't found any examples yet where they strictly didn't have to.