From: Elijah Newren <newren@gmail.com>
Date: Thu, 30 Sep 2010 21:51:49 GMT
Subject: Re: [PATCHv4 15/15] Replace "unset VAR" with "unset VAR;" in testsuite as per t/README
Message-ID: <AANLkTimmSLwZaGvM1j7CQtTzd7mJXSiBDHztj4S97rOr@mail.gmail.com>
In-Reply-To: <7v39srkyax.fsf@alter.siamese.dyndns.org>

On Thu, Sep 30, 2010 at 10:09 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Elijah Newren <newren@gmail.com> writes:
>
>> They break the && cascades, but aren't the && cascades already
>> inherently broken due to the unportable return value of unset?
>
> Of course; that is the breakage you are trying to fix, no?  My comment was
> that I understand you are trying to, but the patch is not actually fixing
> it.
>
> If anything, it is making it worse. Earlier we would have got a false
> breakage that would make people notice and take a look. With your patch
> applied, we instead would let a breakage in parts earlier than these
> "unset VAR;" go unnoticed, no?

Right.

What do you think of the previous suggestions in this thread for a
portable_unset() function, or for using test_might_fail in front of
all these unset commands (despite t/README saying that test_might_fail
is only for running git commands)?