From: Ævar Arnfjörð Bjarmason Date: Thu, 10 Mar 2011 09:21:18 GMT Subject: Re: [PATCH 2/2] i18n: avoid conflict with ngettext from libintl Message-ID: In-Reply-To: <20110309205155.GC22292@elie> On Wed, Mar 9, 2011 at 21:51, Jonathan Nieder wrote: > Junio C Hamano wrote: > >> Hmph.  An obviously safer alternative would be to use git_ngettext() in >> our source all over the place, and it would by even more peace of mind but >> that is even longer. > > Right.  That is tempting. > > Ævar, is there some usual or obvious abbreviated form for ngettext we > could use to avoid this fuss altogether? I was looking yesterday but I couldn't find a common. I think your Q_() is fine. I see GNU Make uses S_() internally, netcat uses PL_(). There seems to be no common convention for it like for gettext(). Personally I'd have chosen n_(), although confusing with our existing N_() we could add dn_(), dcn_() etc for dngettext() and dcngettext() later. But I don't think it matters. Let's use your patch as-is.