From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 25 Sep 2010 14:27:02 GMT
Subject: Re: [PATCH v4 2/4] rev-parse: add tests for git rev-parse --flags.
Message-ID: <AANLkTimj--jZdX++=ZjF3A0HE11FbkgVb2gs3ADVEGvx@mail.gmail.com>
In-Reply-To: <1285421633-22684-3-git-send-email-jon.seymour@gmail.com>

On Sat, Sep 25, 2010 at 13:33, Jon Seymour <jon.seymour@gmail.com> wrote:

> +       : >expected &&

We've been dropping the ":>foo" style in favor of ">foo" in other
tests. There's no need for the ":".

> +       echo -X > expected &&
> +       echo -q > expected &&
> +       echo -X > expected &&
> +       echo --no-flags > expected &&

Maybe some echo implementations don't like flag-like params, and we need:

    printf "%s\n" "-X"

here. I don't know whether that's the case.