From: Jay Soffian Date: Thu, 30 Sep 2010 14:30:42 GMT Subject: Re: [PATCH 00/16] git-send-email cleanups Message-ID: In-Reply-To: <1285854189-10240-1-git-send-email-avarab@gmail.com> On Thu, Sep 30, 2010 at 9:42 AM, Ævar Arnfjörð Bjarmason wrote: > As threatened here's a series that cleans up some of the glaring warts > in git-send-email. > > Ævar Arnfjörð Bjarmason (16): >  send-email: use lexical filehandle for opendir >  send-email: use lexical filehandles for $compose >  send-email: use lexical filehandles during sending >  send-email: get_patch_subject doesn't need a prototype >  send-email: file_declares_8bit_cte doesn't need a prototype >  send-email: unique_email_list doesn't need a prototype >  send-email: cleanup_compose_files doesn't need a prototype >  send-email: use \E***\Q instead of \*\*\* >  send-email: sanitize_address use $foo, not "$foo" >  send-email: sanitize_address use qq["foo"], not "\"foo\"" >  send-email: use (?:) instead of () if no  match variables are needed >  send-email: is_rfc2047_quoted use qr// regexes >  send-email: extract_valid_address use qr// regexes and /o >  send-email: send_message die on $!, not $? >  send-email: make_message_id use "require" instead of "use" >  send-email: use Perl idioms in while loop > >  git-send-email.perl   |   80 +++++++++++++++++++++++------------------------- >  t/t9001-send-email.sh |    2 +- >  2 files changed, 39 insertions(+), 43 deletions(-) These all look pretty uncontroversial and sane by me, though I don't think you touched any of the lines I contributed to git-send-email. If anything, perhaps this series is a bit too granular -- I might combine the commits that get rid of the function prototypes into one for example. Otherwise, thanks for the cleanup. Acked-by: Jay Soffian j.