From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Fri, 12 Nov 2010 08:05:59 GMT
Subject: Re: [PATCHv7 00/11] gitweb: remote_heads feature
Message-ID: <AANLkTimbnwi8B3YtOgxe=qATxOA+baGe=igAa2qQ1e30@mail.gmail.com>
In-Reply-To: <201011112029.22373.jnareb@gmail.com>

2010/11/11 Jakub Narebski <jnareb@gmail.com>:
> On Thu, 11 Nov 2010, Giuseppe Bilotta wrote:
>
>> This 7th version of the remote heads feature for gitweb differs from the
>> previous mostly my small tune-ups, renames of internal functions, some
>> patch reordering and a final addition.
> [...]
>
> I like this version very much.

Thanks.

>> Giuseppe Bilotta (11):
>>   gitweb: use fullname as hash_base in heads link
>>   gitweb: introduce remote_heads feature
>>   gitweb: git_get_heads_list accepts an optional list of refs
>>   gitweb: separate heads and remotes lists
>>   gitweb: nagivation menu for tags, heads and remotes
>>   gitweb: allow action specialization in page header
>>   gitweb: remotes view for a single remote
>>   gitweb: refactor repository URL printing
>>   gitweb: provide a routine to display (sub)sections
>>   gitweb: group remote heads by remote
>>   git instaweb: enable remote_heads
>
> With exception of next to last patch, which contains a few of outdated
> comments (see my response for this commit), I don't see any problems.

I will send a -bis for that patch, with the amended comments.

> So, for the whole series:
>
>  Acked-by: Jakub Narebski <jnareb@gmail.com>
>
>
> Thanks for working diligently on this series, Giuseppe!

Thank _you_ for the thorough review!

-- 
Giuseppe "Oblomov" Bilotta