From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 07 Sep 2010 20:10:50 GMT
Subject: Re: [PATCH 20/20] gettextize: git-am printf(1) message to eval_gettext
Message-ID: <AANLkTim_ovWkPPepB7xRez5DTmJRTrFoZWG+Nx0_O=oL@mail.gmail.com>
In-Reply-To: <1283878224-20202-1-git-send-email-avarab@gmail.com>

Hi,

Ævar Arnfjörð Bjarmason wrote:

> +++ b/git-am.sh
> @@ -778,7 +778,7 @@ did you forget to use 'git add'?"; echo
>        fi
>        if test $apply_status != 0
>        then
> -               printf 'Patch failed at %s %s\n' "$msgnum" "$FIRSTLINE"
> +               echo "$(eval_gettext "Patch failed at \$msgnum \$FIRSTLINE")"

Probably I am missing something silly, but why not just:

        eval_gettext 'Patch failed at $msgnum $FIRSTLINE\n'

? I ask because it is nice to be able to avoid "echo" with arbitrary
data: special characters (e.g. \) can make for portability hassles.

Jonathan