From: Santi Béjar <santi@agolina.net>
Date: Tue, 09 Nov 2010 12:23:20 GMT
Subject: Re: [PATCH/resend] Doc: git-push: Specify the default mode in the description
Message-ID: <AANLkTimYTRvOb1SjjUyANuTX2sCRKj17bLMbkKKG3rFg@mail.gmail.com>
In-Reply-To: <7vy693o833.fsf@alter.siamese.dyndns.org>

On Mon, Nov 8, 2010 at 9:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Santi Béjar <santi@agolina.net> writes:
>
>> Signed-off-by: Santi Béjar <santi@agolina.net>
>> ---
>> Hi *,
>>
>>   just resend a patch that maybe was missed inside this thread:
>
> No, I didn't miss it.
>
> The new text says 'push "matching" branches' before explaining what it is,
> only vaguely refers the reader to the next section by "see below" without
> telling which part of below the reader should look at.  In other words, it
> wastes two lines without adding two lines worth of additional information.
>
> Saying "look for string 'default' below" might be an improvement ;-), but
> then the reader can do that without being told to do so themselves, so...

At least with the new text the reader will know what to look for. She
has to look for "matching" and not the generic "default". BTW, I'll
send another patch with the explanation of matching, but it just
repeats what is written in the <refspec> option...

Another option would be to add "see the <refspec> option below",
although is is already implicit as the paragraph begins with "if no
explicit refspec".

Santi