From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sun, 29 Aug 2010 18:27:22 GMT
Subject: Re: [RFC/PATCH] Add test case for dealing with a tracked file in an ignored directory
Message-ID: <AANLkTimE7LPV0NOdVXZZHgw8=NT061GjjfFYHxVn=X2B@mail.gmail.com>
In-Reply-To: <20100825031341.GF11619@burratino>

On Wed, Aug 25, 2010 at 03:13, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>
>> I just try to
>> (hopefully mostly helpfully) to point out common things that
>> contradict the docs we have
>
> Thanks for doing so, by the way.  One of the best ways to make sure
> the docs are sane is to use them.
>
> When a guideline is unclear, probably I should have been updating the
> docs instead of dispensing advice.
>
> How about something like this?
>
> diff --git a/t/README b/t/README
> index 410499a..f347de7 100644
> --- a/t/README
> +++ b/t/README
> @@ -235,7 +235,9 @@ Do's, don'ts & things to keep in mind
>  -------------------------------------
>
>  Here are a few examples of things you probably should and shouldn't do
> -when writing tests.
> +when writing tests.  If you are editing an existing test script and have
> +the time for it, consider updating the script to follow these guidelines
> +in a separate patch before adding your new test.

That looks good.