From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 01 Oct 2010 00:48:29 GMT
Subject: Re: [PATCHv4 14/15] Add missing &&'s throughout the testsuite
Message-ID: <AANLkTim6ca=8pis2X8Xrc1bGB0YCtYRxCpY3pMdA0QvU@mail.gmail.com>
In-Reply-To: <1285542879-16381-15-git-send-email-newren@gmail.com>

On Sun, Sep 26, 2010 at 23:14, Elijah Newren <newren@gmail.com> wrote:

>  test_expect_success 'did not use upload-pack service' '
> -       grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log >act
> -       : >exp
> +       grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log >act &&
> +       >exp &&
>        test_cmp exp act
>  '

This test started failing in pu, I'm presuming you didn't spot it
since you didn't run the tests with GIT_TEST_HTTPD=1.

Anyway, that grep should be a "! grep" to work with &&.