From: Pavan Kumar Sunkara Date: Sun, 23 May 2010 10:18:15 GMT Subject: Re: [PATCHv3 GSoC] git-instaweb: Configure it to work with new gitweb structure Message-ID: In-Reply-To: <20100523095645.GD3426@dcvr.yhbt.net> On Sun, May 23, 2010 at 3:26 PM, Eric Wong wrote: > Pavan Kumar Sunkara wrote: >> While at it, change apache2 configuration to use the same access log >> and error log files as the rest of web servers supported by >> git-instaweb. > > Hi Pavan, I'm late to this thread, but I'm leaning against forcing > access logs onto people.  I don't believe access logs are necessary for > instaweb.  Error logs are important for debugging breakage, yes, but > access logs aren't worth the trouble IMHO. > > Also, using the same error log paths might make it confusing to people > switching between web servers.  In fact, it may be the most confusing > for those folks if they're trying different web servers and forgetting > to shut down the previous server before starting the next.  They could > end up seeing confusing log messages from the wrong server if they > look in the error log to debug the problem. > > I'm not sure why Mongoose has access logs enabled by default, but I know > I conciously left it out by default for lighttpd/apache/webrick. > > -- > Eric Wong Well, Until before this patch, lighttpd and mongoose have been using the same error log and access log. So, I enabled it for apache2 too in the process of debugging git-instaweb while using apache2. IMVHO If there is no problem using the same logs for lighttpd and mongoose until now, I don't think it will be a problem when apache2 is included into that group. - Pavan >