From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Tue, 10 Aug 2010 20:29:59 GMT
Subject: Re: [PATCH] git-notes: Run partial expensive test everywhere
Message-ID: <AANLkTim2tozO31HKLwxi6kWyZKYMd9egDhS5U_gb5OvZ@mail.gmail.com>
In-Reply-To: <1281470164-27008-1-git-send-email-avarab@gmail.com>

Heya,

On Tue, Aug 10, 2010 at 14:56, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> The git-notes expensive timing test is only expensive because it
> either did 1k iterations or nothing. Change it to do 10 by default,
> with an option to run the expensive version with the old
> GIT_NOTES_TIMING_TESTS=ZomgYesPlease variable.

Nice, why 10 though? Any motivation for that particular value?

> Since nobody was ostensibly running this test under TAP the code had
> bitrotted so that it emitted invalid TAP. This change fixes that.

Nice catch.

> The old version would also mysteriously fail on systems without
> /usr/bin/time, there's now a check for that using the test
> prerequisite facility.

Should this patch be split up?

-- 
Cheers,

Sverre Rabbelier