From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Tue, 26 Oct 2010 16:30:04 GMT
Subject: Re: [PATCHv6 02/10] gitweb: git_get_heads_list accepts an optional list of refs.
Message-ID: <AANLkTim238K41oJAgXJiGMY0E_J_fzQ4b_ovNman2Agn@mail.gmail.com>
In-Reply-To: <201010252356.37472.jnareb@gmail.com>

2010/10/25 Jakub Narebski <jnareb@gmail.com>:
> On Sun, 24 Sep 2010, Giuseppe Bilotta wrote:
>
>>  sub git_get_heads_list {
>> -       my $limit = shift;
>> +       my ($limit, @classes) = @_;
>> +       unless (defined @classes) {
>> +               my $remote_heads = gitweb_check_feature('remote_heads');
>> +               @classes = ('heads', $remote_heads ? 'remotes' : ());
>> +       }
>
> defined(@array) is deprecated at t/../gitweb/gitweb.perl line 3221.
>
> Should be simply 'unless (@classes)', or 'unless (scalar @classes)' but
> conditionals provide boolean context, which is scalar context.
>
> I'm sorry about missing it earlier.

No problem. Fixed for the next batch.

-- 
Giuseppe "Oblomov" Bilotta