From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Sat, 30 Oct 2010 04:38:38 GMT
Subject: Re: [PATCH 38/42] Remove all logic from get_git_work_tree()
Message-ID: <AANLkTim1PBO3TELnRzAGXYK3B0cshzQCwj0udUncfpRb@mail.gmail.com>
In-Reply-To: <AANLkTim-uW4Esk1bkPzNNGRb8svZoNwCUvXF3Fqb4QmR@mail.gmail.com>

2010/10/30 Sverre Rabbelier <srabbelier@gmail.com>:
> Heya,
>
> 2010/10/28 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:
>> This helps break things some more. Eventually all repo setup logic
>> should be centralized in setup_* functions. This helps push all the
>> bugs back to setup_* functions.
>
> I don't know about this, do we really want to willingly break the test
> suite (and fixing it later)? Perhaps we can review this as-is and then
> squash the commits before they are merged to next so that there is no
> breakage? We could even attach the original commits as notes :).

Squashing is no good in terms of readability when we look back in
history. Can git-bisect be taught that "there is breakage in this
segment of commits, consider the whole segment a single commit"?
-- 
Duy