From: Sverre Rabbelier Date: Fri, 29 Oct 2010 17:09:38 GMT Subject: Re: [PATCH 38/42] Remove all logic from get_git_work_tree() Message-ID: In-Reply-To: <1288334934-17216-39-git-send-email-pclouds@gmail.com> Heya, 2010/10/28 Nguyễn Thái Ngọc Duy : > This helps break things some more. Eventually all repo setup logic > should be centralized in setup_* functions. This helps push all the > bugs back to setup_* functions. I don't know about this, do we really want to willingly break the test suite (and fixing it later)? Perhaps we can review this as-is and then squash the commits before they are merged to next so that there is no breakage? We could even attach the original commits as notes :). -- Cheers, Sverre Rabbelier