From: Nguyen Thai Ngoc Duy Date: Wed, 17 Nov 2010 15:02:50 GMT Subject: Re: [PATCH 07/10] checkout: add -S to update sparse checkout Message-ID: In-Reply-To: <87bp5qmez1.fsf@catnip.gol.com> 2010/11/16 Miles Bader : > Jonathan Nieder writes: >>> +-S:: >>> +--update-sparse-checkout:: >>> +    An editor is invoked to let you update your sparse checkout >>> +    patterns. The updated patterns will be saved in >>> +    $GIT_DIR/info/sparse-checkout. The working directory is also >>> +    updated. An empty file will abort the process. >> >> Wording nit: this doesn't make the worktree more up-to-date.  How >> about: >> >>  --edit-sparse-checkout >>  --define-work-area >>  --narrow-worktree >> >> Hmph. >> >> --edit-sparse-checkout seems best for consistency of the choices I can >> think of. > > "--change-sparse-checkout"? > > Onna-account of "edit" sounding like you're actually somehow editting > the checkout itself...  OTOH, since it invokes the editor... hmmm > > BTW, wouldn't it be more convenient to allow specifying patterns > directly via the command line?  I'd think in many (maybe the majority > of) cases people will really only want one entry, and having to edit a > file to specify it seems vaguely annoying... A command line option to append patterns only sounds good to me. But it would clutter up sparse-checkout file over time and may decrease performance. The same option can also be reused for git-clone. Do you suggest any name? I'm bad at naming. I don't think I can make an option to remove patterns though. -- Duy