From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 20 Jul 2010 23:44:23 GMT
Subject: Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail
Message-ID: <AANLkTilzC8iMikfBieS_pcChP7_F4hA6bT1ydWHD4etP@mail.gmail.com>
In-Reply-To: <iU5XdZGtMeaspoCqSJIp6Y--60TPVkZUrm3SdW86dsTZkNYZWqbSppLBrMXyL1rVqqYtHm94ACo@cipher.nrlssc.navy.mil>

On Tue, Jul 20, 2010 at 21:55, Brandon Casey <casey@nrlssc.navy.mil> wrote:

> -       test_must_fail PAGER= git reflog show delta &&
> +       (
> +               PAGER= &&
> +               export PAGER &&
> +               test_must_fail git reflog show delta
> +       ) &&

You must use "export PAGER;", not "export PAGER &&". export doesn't
return zero on all systems when exporting, see previous changes in
this regard in t/.