From: Ævar Arnfjörð Bjarmason Date: Mon, 12 Jul 2010 17:10:06 GMT Subject: Re: [PATCH] Add support for limiting number of lines generated in messages by post-receive-email Message-ID: In-Reply-To: <1278615790-5433-1-git-send-email-kpfleming@digium.com> Just a nit on the format, which might help to get this accepted. This patch has a 84 char subject line, the recommended maximum is 50 (used for --oneline). See Documents/SubmittingPatches. On Thu, Jul 8, 2010 at 19:03, Kevin P. Fleming wrote: > We have become used to the features of svnmailer when used with Subversion, > and one of those useful features is that it can limit the maximum length > (in lines) of a commit email message. This is terribly useful since once the > goes beyond a reasonable number of lines, nobody is going to read the remainder, > and if they really want the entire contents of the commits, they can use > git itself to get them using the revision IDs present in the message already. > > This patch adds a new parameter to the post-receive-email hook script called > 'maxlines', that defaults to 2048 if not specified. The entire message is > filtered through a function that counts the number of lines generated > (including headers), and any lines beyond the limit are suppressed; if any > lines are suppressed, a final line is added indicating the number that > were suppressed. Maybe change the "We have", "This patch" etc. to use the "Changed" wording recommended by Documents/SubmittingPatches?