From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Sun, 09 May 2010 18:43:07 GMT
Subject: Re: [PATCH] diff: fix coloring of extended diff headers
Message-ID: <AANLkTilFfkadPZd56OSGr1yDLVeSQ_G2jOxga1dK5NBD@mail.gmail.com>
In-Reply-To: <591c96c90ca049400a8c0df70f8b44061aeacba5.1272926169.git.bert.wesarg@googlemail.com>

On Tue, May 4, 2010 at 00:38, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> Coloring the extended headers where done as a whole not per line. less with
> option -R (which is the default from git) does not support this coloring
> mode because of performance reasons. The -r option would be an alternative
> but has problems with lines that are longer than the screen. Therefore
> stick to the idiom to color each line separately. The problem is, that the
> result of ill_metainfo() will also be used as an parameter to an external
> diff driver, so we need to disable coloring in this case.
>
> Because coloring is now done inside fill_metainfo() we can simply add this
> string to the diff header and therefore keep the last newline in the
> extended header. This results also into the fact that the external diff
> driver now gets this last newline too. Which is a change in behavior
> but a good one.

Ping.

Regards,
Bert