From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Wed, 21 Jul 2010 00:34:38 GMT
Subject: Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail
Message-ID: <AANLkTil8gyaOcjHGm0tLTdYDdTT4VckUr9nELNiBlKNa@mail.gmail.com>
In-Reply-To: <20100721001402.GE4282@burratino>

On Wed, Jul 21, 2010 at 00:14, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>
>> We should have examples for both export and unset
>
> What is unportable for “export” is the effect of exporting an unset
> variable.  I am not even sure whether the return value is unportable,
> but it doesn’t matter; that is an example of a “Don’t” rather than a
> “Do it this way”.

I didn't know that. It'd be good if it were mentioned in the docs. I
thought it was just export in general.

> See v1.5.6-rc0~61 (filter-branch: fix variable export logic,
> 2008-05-13) for an example.

As an aside, how do you make these 61-commits-after-rc0 commit ids. Is
there a sha1->that tool that I haven't spotted?

>> but the prose
>> should mention both IMO
>
> Yes, thanks for putting this portability guide together.

Thanks for improving it, this change is a definite improvement, I just
had a "wait, what's the export doing there then?" question when
reading it.