From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sun, 30 May 2010 09:38:33 GMT
Subject: Re: [PATCH 5/7] Add API for string-specific memory pool
Message-ID: <AANLkTil6dK82ydjjBqKlHEuDMHbgOlVAUXNQZGHZzCYM@mail.gmail.com>
In-Reply-To: <20100529113800.GA7925@progeny.tock>

Hi Jonathan,

Jonathan Nieder wrote:
> This interns strings so they can be compared by address.  Interesting.
> The use of offsets instead of pointers here mean it is possible to
> back the pool by a file, if I understand correctly.

Exactly. The future plan is to use file backing to support incremental dumps.

> Missing From: and sign-off.

Right, I'll fix this in all the patches in the series in the re-send.

> nitpick: could use fewer parentheses.

Ok.

> so I guess it is safer to keep the casts.

Right. I don't want compiler warnings either- Sverre and I had to work
quite hard to eliminate many of them (commit seen in master now).

> style nitpick: should use space instead of tab

Quick doubt: Does running whitespace-cleanup (Emacs) on all the files
before generating patches suffice?

> Should use "../git-compat-util.h" for portability: unfortunately, some
> platforms git supports still don’t have stdint.h iirc.

Oh. What do we do about stdint.h then?

-- Ram