From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 12 Aug 2010 06:43:38 GMT
Subject: Re: case where diff output needs improving? (was Re: [PATCH v2 0/7] tests: use skip_all=* to skip tests)
Message-ID: <AANLkTiktfhsFWuS5V9aBcuUwQUUAvkc3+q4rhZhTarYP@mail.gmail.com>
In-Reply-To: <87zkwsxsd0.fsf_-_@hariville.hurrynot.org>

On Thu, Aug 12, 2010 at 06:22, Raja R Harinath <harinath@hurrynot.org> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
> [snip]
>>     diff --git a/t/t4016-diff-quote.sh b/t/t4016-diff-quote.sh
>>     index 10e2db3..ab0c2f0 100755
>>     --- a/t/t4016-diff-quote.sh
>>     +++ b/t/t4016-diff-quote.sh
>>     @@ -14 +14 @@ P2='pathname with SP'
>>     -if P3='pathname
>>     +P3='pathname
>>     @@ -16 +16 @@ with LF'
>>     -: 2>/dev/null >"$P1" && test -f "$P1" && rm -f "$P1"
>>     +if : 2>/dev/null >"$P1" && test -f "$P1" && rm -f "$P1"
>
> Assuming this was from a git invocation, it seems that 'diff' could just
> show line 15 instead of '@@ -16, +16 @@' above.

That was from -U0, and showing line 15 would go against the -U0 parameter.