From: Greg Brockman <gdb@mit.edu>
Date: Tue, 27 Jul 2010 22:43:09 GMT
Subject: Re: [PATCHv3] Updated patch series for providing mechanism to list available repositories
Message-ID: <AANLkTikr5jjZJa2irLb2rNew8ngJcv3rhcFV+pNRpRrw@mail.gmail.com>
In-Reply-To: <20100727174105.GA5578@burratino>

Hmm, ok.  So if I'm not mistaken, the only outstanding issue is
whether to provide a way to globally disable git-shell-commands.  Do
you have a particular threat model in mind?

Greg



On Tue, Jul 27, 2010 at 10:41 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Johannes Sixt wrote:
>
>> Windows does have execv. The patch is OK in this regard.
>
> Thanks, that’s a comfort.  Sorry to spread misinformation.
> ---
> diff --git a/compat/mingw.c b/compat/mingw.c
> index 9a8e336..9212a12 100644
> --- a/compat/mingw.c
> +++ b/compat/mingw.c
> @@ -854,6 +854,11 @@ static void mingw_execve(const char *cmd, char *const *argv, char *const *env)
>        }
>  }
>
> +void mingw_execv(const char *cmd, char *const *argv)
> +{
> +       mingw_execve(cmd, argv, environ);
> +}
> +
>  void mingw_execvp(const char *cmd, char *const *argv)
>  {
>        char **path = get_path_split();
> diff --git a/compat/mingw.h b/compat/mingw.h
> index 3b2477b..d81b2f3 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -237,6 +237,9 @@ pid_t mingw_spawnvpe(const char *cmd, const char **argv, char **env,
>  void mingw_execvp(const char *cmd, char *const *argv);
>  #define execvp mingw_execvp
>
> +void mingw_execv(const char *cmd, char *const *argv);
> +#define execv mingw_execv
> +
>  static inline unsigned int git_ntohl(unsigned int x)
>  { return (unsigned int)ntohl(x); }
>  #define ntohl git_ntohl
> --
>